Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 68781 invoked from network); 28 Feb 2011 04:23:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 28 Feb 2011 04:23:37 -0000 Received: (qmail 77694 invoked by uid 500); 28 Feb 2011 04:23:36 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 77278 invoked by uid 500); 28 Feb 2011 04:23:32 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 77271 invoked by uid 99); 28 Feb 2011 04:23:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Feb 2011 04:23:31 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of billnbell@gmail.com designates 209.85.161.48 as permitted sender) Received: from [209.85.161.48] (HELO mail-fx0-f48.google.com) (209.85.161.48) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Feb 2011 04:23:24 +0000 Received: by fxm2 with SMTP id 2so4458849fxm.35 for ; Sun, 27 Feb 2011 20:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=YTiP4/ZGsCdhJHhj/Qlg0xXGanus9qYQhFyuX7Ho394=; b=kTP6BsLhhQgYOXOBq5jybm8lljHP05e63UgS4FtiQJetqDS8rIc1IKqcTJ87OxRdMH OV20A35ihtgyVRAOkBNN6ciX6JaXrucpBFnLHVDFQK9hZ+NdDJn5AEX6MHiofHLhnrj4 cT5b/3F09CkzSCG3KzfZ8Wgp7fIGY6XCBmBpg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=bBBIKPPu+5LpguoamazQfdS6dHb/FOJf3U8LOSMPxgMVQUZzaeaP6DlB7uaIKYV+Di 2MvTDJ36aP/4uvTnYhdU6qHDPtk1LWIse3BKspxuV34GTZG9AG5ssY0yJttTy9X40rI2 EYEyRetBHlsYHh2nVJYsnr8DU4+6UUeUEjJeQ= MIME-Version: 1.0 Received: by 10.223.100.15 with SMTP id w15mr5871010fan.121.1298866983403; Sun, 27 Feb 2011 20:23:03 -0800 (PST) Received: by 10.223.115.17 with HTTP; Sun, 27 Feb 2011 20:23:03 -0800 (PST) In-Reply-To: References: <4893A353-9F9B-4780-9844-2011E71C9B0E@cominvent.com> <1F82A5CC-45FA-4D25-919E-E81A00152A60@cominvent.com> <17E629B6-442F-4E26-B3EA-C574A5AB474B@cominvent.com> Date: Sun, 27 Feb 2011 21:23:03 -0700 Message-ID: Subject: Re: Example schema - fieldType phonetic From: William Bell To: dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org SOLR-2393 Hopefully I cut and pasted properly. On Fri, Feb 25, 2011 at 7:14 AM, Ryan McKinley wrote: > Ya, I suppose the PhoneticFilterFactory could check > "DoubleMetaphone".equals( encoder ) and then create the specialized > Filter. > > I don't feel strongly, but we could have: > EncoderFilter -- just uses 'encode()' > DoubleMetaphoneFilter - uses special double metaphone stuff > > EncoderFilterFactory -- always uses EncoderFilter, and is not > semantically bound to 'phonetic' > PhoneticFilterFactory -- picks the best phonetic filter impl (encoder > or double metaphone) > > then deprecate: > PhoneticFilter > DoubleMetaphoneFilterFactory > > Does that make sense? =C2=A0If so, lets make a JIRA issue for it > > ryan > > > On Fri, Feb 25, 2011 at 4:43 AM, Jan H=C3=B8ydahl = wrote: >> Technically it would be possible for the PhoneticFilterFactory to return= a DoubleMetaphoneFilter for that specific case. Otherwise it would be bett= er to just remove support for DoubleMetaphone from the PhoneticFilterFactor= y and refer to the specialized factory? >> >> -- >> Jan H=C3=B8ydahl, search solution architect >> Cominvent AS - www.cominvent.com >> >> On 25. feb. 2011, at 10.07, Jan H=C3=B8ydahl wrote: >> >>> Then it's funny that only the PhoneticFilter is mentioned on the WIKI w= hile the DoubleMetaphone is not? >>> >>> What would be the correct way to resolve this mismatch aside from fixin= g the documentation? >>> >>> -- >>> Jan H=C3=B8ydahl, search solution architect >>> Cominvent AS - www.cominvent.com >>> >>> On 24. feb. 2011, at 18.10, Ryan McKinley wrote: >>> >>>>> >>>>> Is this difference on purpose? >>>> >>>> If I were to do it again... 'PhoneticFilter' should really be >>>> EncoderFilter since it just uses the encoder API to generate tokens. >>>> There is nothing specific to 'phonetic' -- In fact, when I implement >>>> KStem, I use the PhoneticFilter?! >>>> https://issues.apache.org/jira/browse/SOLR-379?focusedCommentId=3D1293= 4562&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpane= l#comment-12934562 >>>> >>>> DoubleMetaphone however uses the DoubleMetaphone API and generatates >>>> special tokens based on that. >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org >>>> For additional commands, e-mail: dev-help@lucene.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org >>> For additional commands, e-mail: dev-help@lucene.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org >> For additional commands, e-mail: dev-help@lucene.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: dev-help@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org