lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SOLR-1916) investigate DIH use of default locale
Date Tue, 01 Feb 2011 02:14:28 GMT

     [ https://issues.apache.org/jira/browse/SOLR-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated SOLR-1916:
------------------------------

         Priority: Major  (was: Blocker)
    Fix Version/s:     (was: 3.1)

I committed the warning message (1065891, 1065892 in 3x).

Hoping we can improve this one in the future, at least to re-enable the time-related tests.

> investigate DIH use of default locale
> -------------------------------------
>
>                 Key: SOLR-1916
>                 URL: https://issues.apache.org/jira/browse/SOLR-1916
>             Project: Solr
>          Issue Type: Task
>          Components: contrib - DataImportHandler
>    Affects Versions: 3.1, 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.0
>
>         Attachments: SOLR-1916.patch
>
>
> This is a spinoff from LUCENE-2466.
> In this issue I changed my locale to various locales and found some problems in Lucene/Solr
triggered by use of the default Locale.
> I noticed some use of the default-locale for Date operations in DIH (TimeZone.getDefault/Locale.getDefault)
and, while no tests fail, I think it might be better to support a locale parameter for this.
> The wiki documents that numeric parsing can support localized numerics formats: http://wiki.apache.org/solr/DataImportHandler#NumberFormatTransformer
> In both cases, I don't think we should ever use the default Locale. If no Locale is provided,
I find that new Locale("") <-- Unicode Root Locale, is a better default for a server situation
in a lot of cases, as it won't change depending on the computer, or perhaps we just make Locale
params mandatory for this.
> Finally, in both cases, if localized numbers/dates are explicitly supported, I think
we should come up with a test strategy to ensure everything is working. One idea is to do
something similar to or make use of Lucene's LocalizedTestCase.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message