lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (LUCENE-2315) AttributeSource's methods for accessing attributes should be final, else its easy to corrupt the internal states
Date Sun, 27 Feb 2011 14:42:40 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler resolved LUCENE-2315.
-----------------------------------

    Resolution: Fixed

This issue was solved by other commits to trunk (e.g. reflection of AttributeSource), the
last methods were made final in revision: 1075065

> AttributeSource's methods for accessing attributes should be final, else its easy to
corrupt the internal states
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2315
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2315
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>    Affects Versions: 2.9, 2.9.1, 2.9.2, 3.0, 3.0.1
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 4.0
>
>
> The methods that operate and modify the internal maps of AttributeSource should be final,
which is a backwards break. But anybody that overrides such methods simply creates a buggy
AS either case.
> I want to makeall impls final (in general the class should be final at all, but it is
made for extension in TokenStream). So its important that the implementations are final!

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message