lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1416) reduce contention in CoreContainer#getCore()
Date Tue, 22 Feb 2011 05:29:38 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997644#comment-12997644
] 

David Smiley commented on SOLR-1416:
------------------------------------

I don't think ReadWriterLock makes sense when the operation that you're doing is cheap (e.g.
simple hashtable lookups). I argue you've actually slowed things down! I think ConcurrentHashMap
makes the most sense.

Just curious, did you have trepidation about this making you stop short of committing it?
You were a committer when you posted it.

> reduce contention in CoreContainer#getCore()
> --------------------------------------------
>
>                 Key: SOLR-1416
>                 URL: https://issues.apache.org/jira/browse/SOLR-1416
>             Project: Solr
>          Issue Type: Improvement
>          Components: multicore
>            Reporter: Noble Paul
>            Priority: Minor
>         Attachments: SOLR-1416.patch
>
>
> every call to CoreContainer#getCore() is synchronized . We should reduce the contention
. The writes are very infrequent and reads are frequent . How about using a ReadWriterLock?

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message