lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2365) DIH should not be in the Solr war
Date Wed, 16 Feb 2011 07:07:57 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995198#comment-12995198
] 

Erik Hatcher commented on SOLR-2365:
------------------------------------

Since DIH worked out of the box with Solr 1.4.x, we probably want to keep it that way moving
forward (for now).  We should put the <lib> directive into Solr's main example solrconfig.xml
(just we do with clustering, Solr Cell, etc) also.

Other than that, no objections to this.  

[tangent, but ideally we can eventually get all Solr UI to be Velocity generated, and plugins
can then ship with their own .vm files in the JAR file to add in something like a dataimport.jsp]

> DIH should not be in the Solr war
> ---------------------------------
>
>                 Key: SOLR-2365
>                 URL: https://issues.apache.org/jira/browse/SOLR-2365
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-2365_DIH_should_not_be_in_war.patch
>
>
> The DIH has a build.xml that puts itself into the Solr war file.  This is the only contrib
module that does this, and I don't think it should be this way. Granted there is a small dataimport.jsp
file that would be most convenient to remain included, but the jar should not be.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message