lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <>
Subject [jira] Commented: (LUCENE-2923) cleanup contrib/demo
Date Wed, 16 Feb 2011 21:01:24 GMT


Mark Miller commented on LUCENE-2923:

bq. I don't think we should include optimize in the demo; 

I wonder if it wouldn't be better to leave it, but commented out - with a short explanation.

Optimizing is not necessary, but it clearly has benefits to query perf! If you are not updating
often, I think it can make perfect sense.

So I'm fine with just dropping, but not sure if commenting it out and putting something like:
// for an index that is not updated often, we might optimize now

or variation...

> cleanup contrib/demo
> --------------------
>                 Key: LUCENE-2923
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2923.patch
> I don't think we should include optimize in the demo; many people start from the demo
and may think you must optimize to do searching, and that's clearly not the case.
> I think we should also use a buffered reader in FileDocument?
> And... I'm tempted to remove IndexHTML (and the html parser) entirely.  It's ancient,
and we now have Tika to extract text from many doc formats.

This message is automatically generated by JIRA.
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message