lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1226) XPathEntityProcessor should resolve xsl references within Solr's configuration
Date Sat, 19 Feb 2011 05:11:38 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996701#comment-12996701
] 

David Smiley commented on SOLR-1226:
------------------------------------

So this hasn't been committed in 1.5+ years because I didn't write a unit test?  Although
I classified this issue as an "improvement" originally; it is arguably a bug.  *All* resources
referenced in solr config files should be relative to the core conf directory.

> XPathEntityProcessor should resolve xsl references within Solr's configuration
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-1226
>                 URL: https://issues.apache.org/jira/browse/SOLR-1226
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: David Smiley
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-1226.patch
>
>
> The XPathEntityProcessor forces me to use a URL to specify where my XSL file is.  if
it is not a URL, what it should do is attempt to resolve it from Solr's configuration  via
SolrCore.getREsourceLoader().  I have attached a patch which does this.
> Note: it is not clear in the DIH what the concurrency model is and thus I was not certain
that XPathEntityProcessor needs to be thread-safe or not.  So just in case I cached the XSLT
Transformer in a thread-safe manner using a ThreadLocal.  If DIH committers know that it doesn't
have to be thread-safe then some of this code can be simplified.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message