Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of yseeley@gmail.com designates
 209.85.161.48 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:reply-to:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=XExXB/T6KneCLnb40DfE6nRhQ4qW3uhskDMErEaKUFFXZN6A+vSCMngi+a2HcKA87E
         Cea8aN8fO8U6WngzQ4Yn5SpJhx+xcNI1u59lgg1M60MVYBHnT2t3lmE9ryFIzCiufsOx
         y8BgzzAY8j+zhp1+FzpRJq+o4l2nlFIbhIo2U=
MIME-Version: 1.0
Sender: yseeley@gmail.com
Reply-To: yonik@lucidimagination.com
In-Reply-To: <43EF22FC-6E13-4503-9372-60B3C6BF0283@apache.org>
References: <20100925210611.1CB0623888FE@eris.apache.org>
	<43EF22FC-6E13-4503-9372-60B3C6BF0283@apache.org>
Date: Thu, 2 Dec 2010 13:34:02 -0500
Message-ID: <AANLkTikiCVWHrhTABjjgTj4TDMXmbq-BbV516zKFMOE9@mail.gmail.com>
Subject: Re: svn commit: r1001318 - in /lucene/dev/trunk/solr: CHANGES.txt
 src/java/org/apache/solr/search/FunctionQParser.java
 src/test/org/apache/solr/search/QueryParsingTest.java
 src/test/org/apache/solr/search/function/TestFunctionQuery.java
From: Yonik Seeley <yonik@lucidimagination.com>
To: dev@lucene.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 2, 2010 at 12:58 PM, Grant Ingersoll <gsingers@apache.org> wrot=
e:
[...]
> =A0=A0=A0=A0flds =3D sort.getSort();
> =A0=A0=A0=A0assertEquals(flds[0].getType(), SortField.FLOAT);
> =A0=A0=A0=A0assertEquals(flds[0].getField(), "weight");
> -
> - =A0=A0=A0try {
> - =A0=A0=A0=A0=A0//bad number of parens, but the function parser can hand=
le an extra
> close
> - =A0=A0=A0=A0=A0sort =3D QueryParsing.parseSort("pow(weight,2)) desc, bd=
ay asc",
> schema);
> - =A0=A0=A0} catch (SolrException e) {
> - =A0=A0=A0=A0=A0assertTrue(false);
> - =A0=A0=A0}
> +gvim
> =A0=A0=A0=A0//Test literals in functions
> =A0=A0=A0=A0sort =3D QueryParsing.parseSort("strdist(foo_s, \"junk\", jw)=
 desc",
> schema);
> =A0=A0=A0=A0flds =3D sort.getSort();
>
> Namely, it looks like like we had a test that checked for dealing with ex=
tra
> parens.

> Then, perhaps you made some typo that inserted the chars: gvim in
> place of that test.

Yeah - the window you see isn't necessarily the window that has the focus :=
-(

> =A0Subsequently in rev=A01001320 you kind of reverted the
> commit by removing the gvim, but did you intend to restore the test or ar=
e
> you seeing it as a bad test?

It was a bad test.
Tests should test for desired functionality, not quirks or
implementation details of the current implementation.
The fact that the past implementation did not error on something like
"add(a,b))"
was a quirk/bug, not a feature.

-Yonik
http://www.lucidimagination.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org