Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 70676 invoked from network); 2 Dec 2010 11:10:28 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Dec 2010 11:10:28 -0000 Received: (qmail 80105 invoked by uid 500); 2 Dec 2010 11:10:27 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 79996 invoked by uid 500); 2 Dec 2010 11:10:26 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 79989 invoked by uid 99); 2 Dec 2010 11:10:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Dec 2010 11:10:26 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [74.125.82.176] (HELO mail-wy0-f176.google.com) (74.125.82.176) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Dec 2010 11:10:18 +0000 Received: by wyf28 with SMTP id 28so8609676wyf.35 for ; Thu, 02 Dec 2010 03:09:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.187.82 with SMTP id x60mr1527978wem.9.1291288197542; Thu, 02 Dec 2010 03:09:57 -0800 (PST) Received: by 10.216.93.14 with HTTP; Thu, 2 Dec 2010 03:09:57 -0800 (PST) In-Reply-To: References: Date: Thu, 2 Dec 2010 06:09:57 -0500 Message-ID: Subject: Re: Consolidate MP and LMP From: Michael McCandless To: dev@lucene.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org 2010/12/2 Shai Erera : > Hmm .. now that I look closely at it, MP has useCompundFile/DocStore > methods, and LMP just adds getUseCompoundFile(). Why? > And IndexWriter.addIndexes(IndexReader...) queries instanceof LMP, instead > of calling mp.useCompoundFile()? Hmm I don't know. > So perhaps we should: > > 1) Fix IW to not case to LMP just to ask if it should create compound files > or not. And then we can perhaps remove getLogMergePolicy from IW on 3x, and > also removing the source for confusion. Good. > 2) Look at LMP and decide if there are method we believe can be placed on a > general MP, such as mergeFactor or maxMergeDocs. LogMP is special in how it > picks segments for merge - that is, log-based (levels). But maxMergeDocs, > maxMergeSize, mergeFactor, are unrelated to log/levels. This is the sort of > functionality I'd expect to find on a general MP impl. We have to be careful.... eg a future MP could have a minMergeFactor and maxMergeFactor (or, even, no bounds) and so having mergeFactor on the parent isn't great. Mike --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org