lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Resolved: (LUCENE-2820) CMS fails to cleanly stop threads
Date Mon, 20 Dec 2010 10:43:00 GMT


Michael McCandless resolved LUCENE-2820.

    Resolution: Fixed

Take 2!

> CMS fails to cleanly stop threads
> ---------------------------------
>                 Key: LUCENE-2820
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2820.patch
> When you close IW, it waits for (or aborts and then waits for) all running merges.
> However, it's wait criteria is wrong -- it waits for the threads to be done w/ their
merges, not for the threads to actually die.
> CMS already has a sync() method, to wait for running threads, which we can call from
CMS.close.  However it has a thread hazard because a MergeThread removes itself from mergeThreads
before it actually exits.  So sync() is able to return even while a merge thread is still
> This was uncovered by LUCENE-2819 on the test case TestCustomScoreQuery.testCustomExternalQuery,
though I expect other test cases would show it.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message