lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Created: (SOLR-2292) Lock down NamedList API, remove inefficent and esoteric methods
Date Tue, 21 Dec 2010 17:46:01 GMT
Lock down NamedList API, remove inefficent and esoteric methods

                 Key: SOLR-2292
             Project: Solr
          Issue Type: Task
            Reporter: Hoss Man
             Fix For: 3.1

Over in SOLR-2288, rmuir made some good points about locking down the NamedList API to protect

I looked at your patch, and personally I think NamedList should really be type-safe.
If users want to use it in a type-unsafe way, thats fine, but *the container itself shouldn't
be List<Object>*.
Separately, i just want to say the following about NamedList:

All uses of this API should really be reviewed. I'm quite aware that it warns you about the
fact that its slow for certain operations,
but in my opinion these *slow operations such as get(String, int) should be deprecated and

Any users that are using NamedList in this way, especially in loops, are very likely using
the wrong datastructure.

(emphasis added by me)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message