lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-2790) IndexWriter should call MP.useCompoundFile and not LogMP.getUseCompoundFile
Date Thu, 02 Dec 2010 16:47:10 GMT


Michael McCandless commented on LUCENE-2790:

Patch looks great!

My only concern is... it looks like addIndexes(IR[]), with compound file used in the end,
may fail to delete the non-compound files once the SegmentInfo is committed?  Maybe we should
add a test to show the failure...

I think we need to do something like this:
          // delete new non cfs files directly: they were never
          // registered with IFD

> IndexWriter should call MP.useCompoundFile and not LogMP.getUseCompoundFile
> ---------------------------------------------------------------------------
>                 Key: LUCENE-2790
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2790.patch, LUCENE-2790.patch, LUCENE-2790.patch, LUCENE-2790.patch
> Spin off from here:
> I will attach a patch shortly that addresses the issue on trunk.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message