lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2805) SegmentInfos shouldn't blindly increment version on commit
Date Tue, 07 Dec 2010 09:18:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968637#action_12968637
] 

Michael McCandless commented on LUCENE-2805:
--------------------------------------------

Nice catches on all the other places Simon!   Patch looks good.

Except I think we can now simplify IW.nrtIsCurrent to this?
{code}
  synchronized boolean nrtIsCurrent(SegmentInfos infos) {
    return segmentInfos.version == infos.version && !docWriter.anyChanges();
  }
{code}


> SegmentInfos shouldn't blindly increment version on commit
> ----------------------------------------------------------
>
>                 Key: LUCENE-2805
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2805
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Michael McCandless
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2805.patch, LUCENE-2805.patch
>
>
> SegmentInfos currently increments version on the assumption that there are always changes.
> But, both DirReader and IW are more careful about tracking whether there are changes.
 DirReader has hasChanges and IW has changeCount.  I think these classes should notify the
SIS when there are in fact changes; this will fix the case Simon hit on fixing LUCENE-2082
when the NRT reader thought there were changes, but in fact there weren't because IW simply
committed the exact SIS it already had.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message