lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Updated: (LUCENE-2828) SimilarityDelegator broke back-compat for subclasses overriding lengthNorm
Date Tue, 21 Dec 2010 18:44:03 GMT


Michael McCandless updated LUCENE-2828:

    Attachment: LUCENE-2828.patch

Patch w/ test case showing the failure.

> SimilarityDelegator broke back-compat for subclasses overriding lengthNorm
> --------------------------------------------------------------------------
>                 Key: LUCENE-2828
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 3.0.3
>            Reporter: Michael McCandless
>         Attachments: LUCENE-2828.patch
> In LUCENE-1420, we added Similarity.computeNorm to let the norm computation have access
to the raw information (length, boost, etc.).
> But this class broke back compat with SimilarityDelegator.  We did add computeNorm there,
but, it's impl just forwards to the delegee's computeNorm.  In the case where a subclass of
SimilarityDelegator overrides lengthNorm, that method will no longer be invoked.
> Not quite sure how to fix this since, somehow, we have to determine whether the delegee's
impl of computeNorm should be favored over the subclasses impl of the "legacy" lengthNorm.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message