lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Commented: (LUCENE-2824) optimizations for bufferedindexinput
Date Tue, 21 Dec 2010 17:36:02 GMT


Robert Muir commented on LUCENE-2824:

Do these performance comparison tests (posted on 19 December above) have a basic verification
that each query returns the same result, for example a CRC on the matching docids and perhaps
also a CRC on the score values?

Yes, the performance benchmark I used originally came from Mike, it builds on contrib/benchmark,
you can see it here:

It verifies as you suggested, and in fact has found bugs before that our tests don't find...
which frustrates me about our unit tests!

> optimizations for bufferedindexinput
> ------------------------------------
>                 Key: LUCENE-2824
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.1, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-2824.patch
> along the same lines as LUCENE-2816:
> * the readVInt/readVLong/readShort/readInt/readLong are not optimal here since they defer
to readByte. for example this means checking the buffer's bounds per-byte in readVint instead
of per-vint.
> * its an easy win to speed this up, even for the vint case: its essentially always faster,
the only slower case is 1024 single-byte vints in a row, in this case we would do a single
extra bounds check (1025 instead of 1024)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message