lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2790) IndexWriter should call MP.useCompoundFile and not LogMP.getUseCompoundFile
Date Fri, 03 Dec 2010 14:25:10 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shai Erera updated LUCENE-2790:
-------------------------------

    Attachment: LUCENE-2790.patch

Attached adds a test to TestAddIndexes w/ the fix as Mike proposed. The test fails w/o the
fix and passes w/ it.

Also, I noticed that if I don't set noCFSRatio to 1.0, then the added segments are not converted
to a CFS. That is because useCompoundFiles on LMP decides not to do that, because the size
of the segment, which is 377 bytes, is more than 10% of the total index size, which is ...
0. I wonder if we should handle that case, or leave it as is - at some point, when more documents
are added, that segment will be converted to a CFS.

I think that means that the first few segments that will be flushed will remain in non CFS
format. I'm fine w/ it, just making sure I understand this right.

> IndexWriter should call MP.useCompoundFile and not LogMP.getUseCompoundFile
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-2790
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2790
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2790.patch, LUCENE-2790.patch, LUCENE-2790.patch, LUCENE-2790.patch,
LUCENE-2790.patch, LUCENE-2790.patch
>
>
> Spin off from here: http://www.gossamer-threads.com/lists/lucene/java-dev/112311.
> I will attach a patch shortly that addresses the issue on trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message