lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Updated: (LUCENE-2830) Use StringBuilder instead of StringBuffer in benchmark
Date Wed, 22 Dec 2010 09:14:00 GMT


Shai Erera updated LUCENE-2830:

    Attachment: LUCENE-2830.patch

Patch replaces StringBuffer with StringBuilder. I did not yet remove the parse() method from
HtmlParser - if people are ok with it, I'll remove it. For now, I changed the parameter to

All tests pass.

> Use StringBuilder instead of StringBuffer in benchmark
> ------------------------------------------------------
>                 Key: LUCENE-2830
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2830.patch
> Minor change - use StringBuilder instead of StringBuffer in benchmark's code. We don't
need the synchronization of StringBuffer in all the places that I've checked.
> The only place where it _could_ be a problem is in HtmlParser's API - one method accepts
a StringBuffer and it's an interface. But I think it's ok to change benchmark's API, back-compat
wise and so I'd like to either change it to accept a String, or remove the method altogether
-- no code in benchmark uses it, and if anyone needs it, he can pass StringReader to the other

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message