Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 23575 invoked from network); 19 Nov 2010 18:32:06 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Nov 2010 18:32:06 -0000 Received: (qmail 31740 invoked by uid 500); 19 Nov 2010 18:32:37 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 31687 invoked by uid 500); 19 Nov 2010 18:32:37 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 31680 invoked by uid 99); 19 Nov 2010 18:32:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Nov 2010 18:32:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Nov 2010 18:32:34 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAJIWDjo022154 for ; Fri, 19 Nov 2010 18:32:13 GMT Message-ID: <5743179.200761290191533304.JavaMail.jira@thor> Date: Fri, 19 Nov 2010 13:32:13 -0500 (EST) From: "Uwe Schindler (JIRA)" To: dev@lucene.apache.org Subject: [jira] Resolved: (LUCENE-2770) Optimize SegmentMerger to work on atomic (Segment)Readers where possible In-Reply-To: <22204682.197741290183313434.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-2770. ----------------------------------- Resolution: Fixed Committed trunk revision: 1036970 Committed 3.x revision: 1036971 Thanks Mike for the help with the stupid bug because of not-cloned TVReader! > Optimize SegmentMerger to work on atomic (Segment)Readers where possible > ------------------------------------------------------------------------ > > Key: LUCENE-2770 > URL: https://issues.apache.org/jira/browse/LUCENE-2770 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Priority: Minor > Fix For: 3.1, 4.0 > > Attachments: LUCENE-2770-3x.patch, LUCENE-2770-3x.patch, LUCENE-2770.patch, LUCENE-2770.patch, LUCENE-2770.patch > > > This is a spin-off from LUCENE-2769: > Currently SegmentMerger has some optimizations when it merges segments that are SegmentReaders (e.g. when doing normal indexing or optimizing). But when you do IndexWriter.addIndexes(IndexReader...) the listed IndexReaders may not really be per-segment. SegmentMerger should track down all passed in reads down to the lowest level (Segment)Reader (or other atomic readers like SlowMultiReaderWrapper) and then merge. We can then remove most MultiFields usage (except term merging itsself) and clean up the code. > This especially saves lots of memory for merging norms, as no longer the duplicate norms arrays are created when MultiReaders are used! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org