Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 53347 invoked from network); 25 Nov 2010 13:08:40 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Nov 2010 13:08:40 -0000 Received: (qmail 32990 invoked by uid 500); 25 Nov 2010 13:08:38 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 32901 invoked by uid 500); 25 Nov 2010 13:08:38 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 32889 invoked by uid 99); 25 Nov 2010 13:08:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Nov 2010 13:08:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Nov 2010 13:08:35 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAPD8Do3026873 for ; Thu, 25 Nov 2010 13:08:14 GMT Message-ID: <11703886.307791290690493941.JavaMail.jira@thor> Date: Thu, 25 Nov 2010 08:08:13 -0500 (EST) From: "Trejkaz (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-2348) DuplicateFilter incorrectly handles multiple calls to getDocIdSet for segment readers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935748#action_12935748 ] Trejkaz commented on LUCENE-2348: --------------------------------- I don't really want to argue good or bad design, because the fact is that it worked, and then Lucene core broke the functionality, and now you are claiming that some kinds of filter shouldn't be done as a filter anymore (what should they be done as, then? I've already said that the other suggestions won't work in any fashion.) But fine. This wasn't the only filter in our system affected by this issue. As long as LUCENE-2506 is put through, though, the rest of our filters which are _not_ "bad design" will still be able to work in the future without hacks on our end to make them work. > DuplicateFilter incorrectly handles multiple calls to getDocIdSet for segment readers > ------------------------------------------------------------------------------------- > > Key: LUCENE-2348 > URL: https://issues.apache.org/jira/browse/LUCENE-2348 > Project: Lucene - Java > Issue Type: Bug > Components: contrib/* > Affects Versions: 2.9.2 > Reporter: Trejkaz > Attachments: LUCENE-2348.patch, LUCENE-2348.patch > > > DuplicateFilter currently works by building a single doc ID set, without taking into account that getDocIdSet() will be called once per segment and only with each segment's local reader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org