lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2739) Refactor TestIndexWriter
Date Thu, 04 Nov 2010 16:49:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928274#action_12928274
] 

Robert Muir commented on LUCENE-2739:
-------------------------------------

Ok, i'll commit + merge, then take a look if there's any other obvious steps we can make here.

but this one is simple and speeds up the tests a lot :)

> Refactor TestIndexWriter
> ------------------------
>
>                 Key: LUCENE-2739
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2739
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Build
>            Reporter: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in
TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message