lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Date Tue, 30 Nov 2010 03:32:10 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-2781:
--------------------------------

    Attachment: LUCENE-2781.patch

Earwin's patch: I only restored anything necessary for 3.0+ analyzer back compat (along with
any back-compat tests).
All tests pass... in my opinion the patch is sorely needed!

I think Earwin's suggestion here makes a ton of sense:
* Lets say you are on Lucene 2.4, when you upgrade to 3.0, it continues to provide you backwards
compat via the version constant, but Version.LUCENE_24 becomes is deprecated, so its a deprecation
in your code you know you must fix, before you move to 4.0. At your leisure, sometime during
the entire 3.0-3.9 or whatever, you migrate to Version.LUCENE_30 and the deprecation goes
away.
* When you move to Lucene 4.0, the Version.LUCENE_24 stuff etc stuff is gone, but its no surprise,
because you are guided via deprecations. 4.0 doesnt support 2.x indexes anyway.

So I'm strongly +1 to committing this 2.3MB patch that removes 100,000 lines of crap from
trunk.


> Drop deprecations from trunk
> ----------------------------
>
>                 Key: LUCENE-2781
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2781
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Earwin Burrfoot
>            Assignee: Robert Muir
>            Priority: Minor
>         Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch,
drop-deprecations.patch, LUCENE-2781.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message