lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2762) Don't leak deleted open file handles with pooled readers
Date Mon, 15 Nov 2010 18:14:13 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-2762:
---------------------------------------

    Attachment: LUCENE-2762.patch

Patch.

I made a new test case showing the problem (and also modified a
pre-existing test case to also show the problem).  Patch includes the
fix (I don't commit the merged segment until after the CFS is built)
and both tests now pass.

I also added a new core test utility class (LineFileDocs) that's able
to read line files produced by contrib/benchmark, and the new test
uses this to index the line for Wikipedia.  I think we should somehow
mark this test to run only at night on hudson eg with a new @nightly
tag or something... it's already disabled if it can't find the line
file, though it's now hardwired to the line file location in my env.

In general I think our tests should sometimes use "real" data so if we
can get this wikipedia line file in a standard place on hudson then
longer-running @nightly tests can use it...


> Don't leak deleted open file handles with pooled readers
> --------------------------------------------------------
>
>                 Key: LUCENE-2762
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2762
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9.4, 3.0.3, 3.1, 4.0
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2762.patch
>
>
> If you have CFS enabled today, and pooling is enabled (either directly
> or because you've pulled an NRT reader), IndexWriter will hold open
> SegmentReaders against the non-CFS format of each merged segment.
> So even if you close all NRT readers you've pulled from the writer,
> you'll still see file handles open against files that have been
> deleted.
> This count will not grow unbounded, since it's limited by the number
> of segments in the index, but it's still a serious problem since the
> app had turned off CFS in the first place presumably to avoid risk of
> too-many-open-files.  It's also bad because it ties up disk space
> since these files would otherwise be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message