lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2785) TopFieldCollector throws AIOOBE if numHits is 0
Date Tue, 30 Nov 2010 10:54:11 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965192#action_12965192
] 

Uwe Schindler commented on LUCENE-2785:
---------------------------------------

bq. So... IndexSearcher.search (the one that sorts by score) throws an EXC if numHits is 0...
Maybe... we should do the same for the sort-by-field case?

I think IndexSearcher should not only throw the exception, in my opinion the create() method
in TSDC and TFDC should also check this and throw the exception? A lot of people, also solr
are instantiating the collectors themselves (although not recommeneded, because they dont
know the correct booleans passed in).

+1 for TSDC and TFDC throw exception if hitcount <1

bq. And, also make this new Collector that only counts hits? The exception message can then
point users to this new Collector?

+1 to the new collector that simply counts. I have such a collector also sometimes in my code.
Misusing TFDC or TSDC is wrong and uses too much resources.

> TopFieldCollector throws AIOOBE if numHits is 0
> -----------------------------------------------
>
>                 Key: LUCENE-2785
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2785
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>            Reporter: Michael McCandless
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>
> See solr-user thread "ArrayIndexOutOfBoundsException for query with rows=0 and sort param".
> I think we should just create a null collector (only tallies up totalHits) if numHits
is 0?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message