lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Updated: (LUCENE-2769) FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
Date Fri, 19 Nov 2010 09:58:14 GMT


Robert Muir updated LUCENE-2769:

    Attachment: LUCENE-2769_norms.patch

here's another hacky update: but still a few tests explicitly check these norms and need to
be fixed.

maybe we could add an uncached "MultiNorms" or something at least in src/test for convenience,
just to fill the byte arrays so these tests can assertEquals

otherwise we are going to have to put a lot of SlowMultiReaderWrappers in these tests.

> FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
> ---------------------------------------------------------------------------------
>                 Key: LUCENE-2769
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-2769.patch, LUCENE-2769.patch, LUCENE-2769_norms.patch, LUCENE-2769_norms.patch
> Since LUCENE-2459, getSequentialSubReaders() in FilterIndexReader returns null, so it
returns an atomic reader. But If you call then any of the enum methods, it throws Exception
because the underlying reader is not atomic.
> We should move the null-returning method to SlowMultiReaderWrapper and fix FilterIndexReader's
default to return in.getSequentialSubReaders(). Ideally an implementation must of course also
wrap the sub-readers.
> If we change this we have to look into other Impls like the MultiPassIndexSplitter if
we need to add atomicity.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message