lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2769) FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
Date Fri, 19 Nov 2010 08:59:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933729#action_12933729
] 

Uwe Schindler commented on LUCENE-2769:
---------------------------------------

Additionally to this:
The MultiPassIndexSplitter in 3.x and 3.0 should also return null in getSeqSubReaders. It
works currently because we know how SegmentMerger works, but its still incorrect. To Filter
the terms correctly it should imitate a atomic reader.

> FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-2769
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2769
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-2769.patch, LUCENE-2769.patch
>
>
> Since LUCENE-2459, getSequentialSubReaders() in FilterIndexReader returns null, so it
returns an atomic reader. But If you call then any of the enum methods, it throws Exception
because the underlying reader is not atomic.
> We should move the null-returning method to SlowMultiReaderWrapper and fix FilterIndexReader's
default to return in.getSequentialSubReaders(). Ideally an implementation must of course also
wrap the sub-readers.
> If we change this we have to look into other Impls like the MultiPassIndexSplitter if
we need to add atomicity.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message