lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2778) Allow easy extension of RAMDirectory
Date Mon, 29 Nov 2010 11:39:38 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964705#action_12964705
] 

Robert Muir commented on LUCENE-2778:
-------------------------------------

Here's my take: personally i don't see any problem with how Shai works here, as long
as its still a proper merge. The mergeprops on things like Tokenizer aren't his fault, its
because
someone merged incorrectly before.

I just suggest we do the following:
* always svn update before merging
* always merge from top-level svn root (if you merged from some other location, then merge
again from top level before committing)

I cleaned up the mergeprops yesterday so the problems Yonik sees shouldn't happen anymore.
but: its important people do proper merging so that we don't end up in this situation.


> Allow easy extension of RAMDirectory
> ------------------------------------
>
>                 Key: LUCENE-2778
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2778
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2778.patch
>
>
> RAMDirectory uses RAMFiles to store the data. RAMFile offers a newBuffer() method for
extensions to override and allocate buffers differently, from e.g. a pool or something. However,
RAMDirectory always allocates RAMFile and doesn't allow allocating a RAMFile extension, which
makes RAMFile.newBuffer() unusable.
> I think we can simply introduce a newRAMFile() method on RAMDirectory and make the RAMFiles
map protected, and it will allow really extending RAMDir.
> I will post a patch later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message