lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2770) Optimize SegmentMerger to work on atomic (Segment)Readers where possible
Date Fri, 19 Nov 2010 23:20:13 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-2770:
----------------------------------

    Attachment: LUCENE-2770-optimizeNormsMerging.patch

After a discussion with Robert, I supply a new patch with optrimized norms merging without
reallocating and ArrayUtil.oversize() (implied y BytesRef). The fix is now to simply look
before starting to merge norms how big the normsBuffer must be. So there is never reallocation
needed.

Will heavy commit now :-)

> Optimize SegmentMerger to work on atomic (Segment)Readers where possible
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2770
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2770
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2770-3x.patch, LUCENE-2770-3x.patch, LUCENE-2770-optimizeNormsMerging.patch,
LUCENE-2770.patch, LUCENE-2770.patch, LUCENE-2770.patch
>
>
> This is a spin-off from LUCENE-2769:
> Currently SegmentMerger has some optimizations when it merges segments that are SegmentReaders
(e.g. when doing normal indexing or optimizing). But when you do IndexWriter.addIndexes(IndexReader...)
the listed IndexReaders may not really be per-segment. SegmentMerger should track down all
passed in reads down to the lowest level (Segment)Reader (or other atomic readers like SlowMultiReaderWrapper)
and then merge. We can then remove most MultiFields usage (except term merging itsself) and
clean up the code.
> This especially saves lots of memory for merging norms, as no longer the duplicate norms
arrays are created when MultiReaders are used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message