lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2764) Allow tests to use random codec per field
Date Wed, 17 Nov 2010 11:27:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932910#action_12932910
] 

Michael McCandless commented on LUCENE-2764:
--------------------------------------------

bq. The problem is if we have IW writing field A with codec Standard then open a new IW with
field A using PreFlexRW we get problems with the comparator if those segments are merged though.

Hmm this should be OK...

The PreFlexRW codec has a sneaky "impersonation" layer (test only)
that attempts to figure out which term comparator it's supposed to be
using when something is reading the segment.  It sounds like that
layer isn't being smart enough now.

I think we could fix it -- really it just needs to know which codec is
"writing".  If it's PreFlexRW that's writing then it needs to use the
legacy sort order; else, unicode.


> Allow tests to use random codec per field
> -----------------------------------------
>
>                 Key: LUCENE-2764
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2764
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2764.patch, LUCENE-2764.patch
>
>
> Since we now have a real per field codec support we should enable to run the tests with
a random codec per field. When I change something related to codecs internally I would like
to ensure that whatever combination of codecs (except of preflex) I use the code works just
fine. I created a RandomCodecProvider in LuceneTestCase that randomly selects the codec for
fields when it sees them the first time. I disabled the test by default to leave the old randomize
codec support in as it was / is.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message