lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Updated: (LUCENE-2769) FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
Date Fri, 19 Nov 2010 12:47:13 GMT


Robert Muir updated LUCENE-2769:

    Attachment: LUCENE-2769_norms.patch

here is an updated patch, with core/contrib/solr tests passing.

For ParallelReader i forced it to require non-composite readers only (e.g. SlowMultiReaderWrap
them if thats not the case).

* ParallelReader shouldnt need multifields etc anymore
* there are 5 @Ignore'd ParallelReader-related tests, because of things like reopen/isOptimized/isCurrent
* merge in Uwe's improved SegmentsMerger
* clean up code.

> FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
> ---------------------------------------------------------------------------------
>                 Key: LUCENE-2769
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-2769.patch, LUCENE-2769.patch, LUCENE-2769_norms.patch, LUCENE-2769_norms.patch,
LUCENE-2769_norms.patch, LUCENE-2769_SegmentMerger.patch
> Since LUCENE-2459, getSequentialSubReaders() in FilterIndexReader returns null, so it
returns an atomic reader. But If you call then any of the enum methods, it throws Exception
because the underlying reader is not atomic.
> We should move the null-returning method to SlowMultiReaderWrapper and fix FilterIndexReader's
default to return in.getSequentialSubReaders(). Ideally an implementation must of course also
wrap the sub-readers.
> If we change this we have to look into other Impls like the MultiPassIndexSplitter if
we need to add atomicity.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message