lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2778) Allow easy extension of RAMDirectory
Date Fri, 26 Nov 2010 20:33:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12936093#action_12936093
] 

Shai Erera commented on LUCENE-2778:
------------------------------------

That's how I worked so far ... I usually develop on 3x and then merge to trunk. I didn't think
it will cause troubles :). I don't mind developing on trunk and merging to 3x if that will
improve anything, but would the history of 3x look like then? Perhaps we should avoid merging
on a regular basis and instead apply the patch on both, and then once in a while we do a big
mergeprops merge?

> Allow easy extension of RAMDirectory
> ------------------------------------
>
>                 Key: LUCENE-2778
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2778
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2778.patch
>
>
> RAMDirectory uses RAMFiles to store the data. RAMFile offers a newBuffer() method for
extensions to override and allocate buffers differently, from e.g. a pool or something. However,
RAMDirectory always allocates RAMFile and doesn't allow allocating a RAMFile extension, which
makes RAMFile.newBuffer() unusable.
> I think we can simply introduce a newRAMFile() method on RAMDirectory and make the RAMFiles
map protected, and it will allow really extending RAMDir.
> I will post a patch later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message