lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2769) FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
Date Fri, 19 Nov 2010 18:36:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933907#action_12933907
] 

Robert Muir commented on LUCENE-2769:
-------------------------------------

I thought about this more, i think for this issue, we should not make SlowMultiReaderWrapper
complicated and force ParallelReader to take atomic readers.

instead, we should remove norms from Multi/DirReader like my patch suggests and make ParallelReader
manage its own cached norms. 

For ParallelReader, this is no worse than today, but no better either. We should seriously
either figure out how to 
fix this ParallelReader or move it to contrib.

> FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-2769
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2769
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-2769.patch, LUCENE-2769.patch, LUCENE-2769_norms.patch, LUCENE-2769_norms.patch,
LUCENE-2769_norms.patch
>
>
> Since LUCENE-2459, getSequentialSubReaders() in FilterIndexReader returns null, so it
returns an atomic reader. But If you call then any of the enum methods, it throws Exception
because the underlying reader is not atomic.
> We should move the null-returning method to SlowMultiReaderWrapper and fix FilterIndexReader's
default to return in.getSequentialSubReaders(). Ideally an implementation must of course also
wrap the sub-readers.
> If we change this we have to look into other Impls like the MultiPassIndexSplitter if
we need to add atomicity.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message