lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "peterwang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-236) Field collapsing
Date Wed, 17 Nov 2010 11:22:06 GMT

    [ https://issues.apache.org/jira/browse/SOLR-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932905#action_12932905
] 

peterwang commented on SOLR-236:
--------------------------------

SOLR-236-1_4_1-paging-totals-working.patch patch failed with following errors:

patch: **** malformed patch at line 3348: Index: src/test/org/apache/solr/search/fieldcollapse/DistributedFieldCollapsingIntegrationTest.java

seems caused by hand edit (delete 6 lines without fix diff hunk number) patch files, possible
fix:

# diff -u SOLR-236-1_4_1.patch SOLR-236-1_4_1-paging-totals-working.patch
--- SOLR-236-1_4_1.patch        2010-11-17 18:22:25.000000000 +0800
+++ SOLR-236-1_4_1-paging-totals-working.patch  2010-11-17 19:17:20.000000000 +0800
@@ -2834,7 +2834,7 @@
 ===================================================================
 --- src/java/org/apache/solr/search/fieldcollapse/NonAdjacentDocumentCollapser.java    (revision
)
 +++ src/java/org/apache/solr/search/fieldcollapse/NonAdjacentDocumentCollapser.java    (revision
)
-@@ -0,0 +1,517 @@
+@@ -0,0 +1,511 @@
 +/**
 + * Licensed to the Apache Software Foundation (ASF) under one or more
 + * contributor license agreements.  See the NOTICE file distributed with
@@ -2939,12 +2939,6 @@
 +        collapseDoc = new NonAdjacentCollapseGroup(0, 0, documentComparator, collapseThreshold,
currentValue);
 +        collapsedDocs.put(currentValue, collapseDoc);
 +        collapsedGroupPriority.add(collapseDoc);
-+
-+        if (collapsedGroupPriority.size() > maxNumberOfGroups) {
-+          NonAdjacentCollapseGroup inferiorGroup = collapsedGroupPriority.first();
-+          collapsedDocs.remove(inferiorGroup.fieldValue);
-+          collapsedGroupPriority.remove(inferiorGroup);
-+        }
 +      }
 +      // dropoutId has a value smaller than the smallest value in the queue and therefore
it was removed from the queue
 +      Integer dropOutId = (Integer) collapseDoc.priorityQueue.insertWithOverflow(currentId);



> Field collapsing
> ----------------
>
>                 Key: SOLR-236
>                 URL: https://issues.apache.org/jira/browse/SOLR-236
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Emmanuel Keller
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Next
>
>         Attachments: collapsing-patch-to-1.3.0-dieter.patch, collapsing-patch-to-1.3.0-ivan.patch,
collapsing-patch-to-1.3.0-ivan_2.patch, collapsing-patch-to-1.3.0-ivan_3.patch, DocSetScoreCollector.java,
field-collapse-3.patch, field-collapse-4-with-solrj.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-solr-236-2.patch, field-collapse-solr-236.patch, field-collapsing-extended-592129.patch,
field_collapsing_1.1.0.patch, field_collapsing_1.3.patch, field_collapsing_dsteigerwald.diff,
field_collapsing_dsteigerwald.diff, field_collapsing_dsteigerwald.diff, NonAdjacentDocumentCollapser.java,
NonAdjacentDocumentCollapserTest.java, quasidistributed.additional.patch, SOLR-236-1_4_1-paging-totals-working.patch,
SOLR-236-1_4_1.patch, SOLR-236-FieldCollapsing.patch, SOLR-236-FieldCollapsing.patch, SOLR-236-FieldCollapsing.patch,
SOLR-236-trunk.patch, SOLR-236-trunk.patch, SOLR-236-trunk.patch, SOLR-236-trunk.patch, SOLR-236-trunk.patch,
SOLR-236.patch, SOLR-236.patch, SOLR-236.patch, SOLR-236.patch, SOLR-236.patch, SOLR-236.patch,
SOLR-236.patch, SOLR-236.patch, solr-236.patch, SOLR-236_collapsing.patch, SOLR-236_collapsing.patch
>
>
> This patch include a new feature called "Field collapsing".
> "Used in order to collapse a group of results with similar value for a given field to
a single entry in the result set. Site collapsing is a special case of this, where all results
for a given web site is collapsed into one or two entries in the result set, typically with
an associated "more documents from this site" link. See also Duplicate detection."
> http://www.fastsearch.com/glossary.aspx?m=48&amid=299
> The implementation add 3 new query parameters (SolrParams):
> "collapse.field" to choose the field used to group results
> "collapse.type" normal (default value) or adjacent
> "collapse.max" to select how many continuous results are allowed before collapsing
> TODO (in progress):
> - More documentation (on source code)
> - Test cases
> Two patches:
> - "field_collapsing.patch" for current development version
> - "field_collapsing_1.1.0.patch" for Solr-1.1.0
> P.S.: Feedback and misspelling correction are welcome ;-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message