Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of rcmuir@gmail.com designates
 209.85.161.48 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=JGy0ZdGXqmCYtCgpGmxWLxOvhFW51KI4dfzQymEsPSb99LTMILbjJAnL5tHmislHrN
         0xSpP0rOAKXoCxvTigS5Y071av05+fEiPOQNzYAoL9qHm+lE/QgdTtwX6f/YFx1/qItx
         HhRbMNfZhHHGAw7eUlVEUYoafduX0gu5aJdB8=
MIME-Version: 1.0
In-Reply-To: <007301cb6faa$1b27d5b0$51778110$@thetaphi.de>
References: <20101019161236.D80C323888FD@eris.apache.org>
 <007301cb6faa$1b27d5b0$51778110$@thetaphi.de>
From: Robert Muir <rcmuir@gmail.com>
Date: Wed, 20 Oct 2010 09:27:13 -0400
Message-ID: <AANLkTi=_rB_5GpoAfTixMHFX7eG076umR0T1YL2pXPeT@mail.gmail.com>
Subject: Re: svn commit: r1024305 - in
 /lucene/dev/trunk/solr/src/test/org/apache/solr/core:
 SolrCoreTest.java TestPropInjectDefaults.java
To: dev@lucene.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 19, 2010 at 12:24 PM, Uwe Schindler <uwe@thetaphi.de> wrote:
> Yonik,
>
> Just to reduce the work you have to do: With a subclass of LuceneTestCase=
, you don't need to add @Test, as the internal test runner behaves like JUn=
it3 and runs all public methods starting with "test" (in addition to @Test =
annotated,m which is still supported and used). We did this, as a lot of te=
sts were forgotten to be upgraded correctly. Now Lucene runs on JUnit4 API =
(with static @BeforeClass and all nice stuff, @Ignore, assume*,...), but no=
 test had to be changed :-) Also LuceneTestCase extends Assert, so no stati=
c imports :-)
>

Well, just for thoroughness you might have to slightly change some
Junit3 tests (for example, ones on very old patches).
In most cases the junit3-style tests will work just fine, but there
are two cases where you will get a compile error:

1. Tests that have constructors like this:

public TestToken(String name) {
  super(name);
}

in this case just delete these useless constructors

2. Tests that have setUp or tearDown as protected (not public!)

protected void setUp() throws Exception {
  ...
}

in this case, these must be changed to public, since setUp() is public
in LuceneTestCase (and must be for the @Before to work).

If this is confusing, see
https://issues.apache.org/jira/browse/LUCENE-2642 for some examples of
tests that were changed in this way.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org