Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 31187 invoked from network); 25 Oct 2010 02:20:46 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Oct 2010 02:20:46 -0000 Received: (qmail 92716 invoked by uid 500); 25 Oct 2010 02:20:44 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 92649 invoked by uid 500); 25 Oct 2010 02:20:44 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 92615 invoked by uid 99); 25 Oct 2010 02:20:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Oct 2010 02:20:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Oct 2010 02:20:42 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9P2KLRa006536 for ; Mon, 25 Oct 2010 02:20:21 GMT Message-ID: <31478019.52621287973221324.JavaMail.jira@thor> Date: Sun, 24 Oct 2010 22:20:21 -0400 (EDT) From: "Mark Miller (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (SOLR-1674) improve analysis tests, cut over to new API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924431#action_12924431 ] Mark Miller commented on SOLR-1674: ----------------------------------- Going to close this if no one objects... > improve analysis tests, cut over to new API > ------------------------------------------- > > Key: SOLR-1674 > URL: https://issues.apache.org/jira/browse/SOLR-1674 > Project: Solr > Issue Type: Test > Components: Schema and Analysis > Reporter: Robert Muir > Assignee: Mark Miller > Fix For: 1.5, 3.1, 4.0 > > Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch > > > This patch > * converts all analysis tests to use the new tokenstream api > * converts most tests to use the more stringent assertion mechanisms from lucene > * adds new tests to improve coverage > Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter. > The problems with this filter are more serious, the previous tests were essentially a no-op. > The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org