Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 39276 invoked from network); 31 Oct 2010 14:52:50 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 31 Oct 2010 14:52:50 -0000 Received: (qmail 28244 invoked by uid 500); 31 Oct 2010 14:52:47 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 27936 invoked by uid 500); 31 Oct 2010 14:52:47 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 27920 invoked by uid 99); 31 Oct 2010 14:52:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Oct 2010 14:52:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Oct 2010 14:52:44 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9VEqN6B022348 for ; Sun, 31 Oct 2010 14:52:24 GMT Message-ID: <27835862.162501288536743657.JavaMail.jira@thor> Date: Sun, 31 Oct 2010 10:52:23 -0400 (EDT) From: "Uwe Schindler (JIRA)" To: dev@lucene.apache.org Subject: [jira] Resolved: (LUCENE-2732) Fix charset problems in XML loading in HyphenationCompoundWordTokenFilter (also Solr's loader from schema) In-Reply-To: <1578018.161881288527203362.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-2732. ----------------------------------- Resolution: Fixed Committed 3.0 revision: 1029374 Committed 2.9 revision: 1029375 > Fix charset problems in XML loading in HyphenationCompoundWordTokenFilter (also Solr's loader from schema) > ---------------------------------------------------------------------------------------------------------- > > Key: LUCENE-2732 > URL: https://issues.apache.org/jira/browse/LUCENE-2732 > Project: Lucene - Java > Issue Type: Bug > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: 2.9.4, 3.0.3, 3.1, 4.0 > > Attachments: LUCENE-2732.patch, LUCENE-2732.patch > > > As said in LUCENE-2731, the handling of XML in HyphenationCompoundWordTokenFilter is broken and breaks XML 1.0 (5th edition) spec totally. You should never supply a Reader to any XML api, unless you have internal character data (e.g. created programmatically). Also you should supply a system id, as resolving external entities does not work. The loader from files is much more broken, it always open the file as a Reader and then passes it to InputSource. Instead it should point filename directly to InputSource. > This issue will fix it in trunk and use InputSource in Solr, but will still supply the Reader possibility in previous versions (deprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org