Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Message-ID: <26678660.13241287688215656.JavaMail.jira@thor>
Date: Thu, 21 Oct 2010 15:10:15 -0400 (EDT)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2716) Improve automaton's
 MinimizeOperations.minimizeHopcroft() to not create so many objects
In-Reply-To: <21503621.12141287684255017.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923572#action_12923572 ] 

Robert Muir commented on LUCENE-2716:
-------------------------------------

Ok, I fixed LUCENE-2717 in revision 1026104.

In that issue, I added a basic random test for minimize(), maybe we can improve it, but
it should be pretty good at finding any bugs.

(it doesnt find any bugs with this patch)

> Improve automaton's MinimizeOperations.minimizeHopcroft() to not create so many objects
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2716
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2716
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2716.patch
>
>
> MinimizeOperations.minimizeHopcroft() creates a lot of objects because of strange arrays and useless ArrayLists with fixed length. E.g. it created List<List<List<>>>. This patch minimizes this and makes the whole method much more GC friendler by using simple arrays or avoiding empty LinkedLists at all (inside reverse array). 
> minimize() is called very very often, especially in tests (MockAnalyzer).
> A test for the method is prepared by Robert, we found a bug somewhere else in automaton, so this is pending until his issue and fix arrives.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org