Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Message-ID: <11890441.42361287479966536.JavaMail.jira@thor>
Date: Tue, 19 Oct 2010 05:19:26 -0400 (EDT)
From: "Michael McCandless (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2643) StringHelper#stringDifference is
 wrong about supplementary chars
In-Reply-To: <24914030.179281284472837772.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922493#action_12922493 ] 

Michael McCandless commented on LUCENE-2643:
--------------------------------------------

Why not drop it from 3.x/3.0.x as well?

It's an internal API so there's no need to deprecate it first?

> StringHelper#stringDifference is wrong about supplementary chars 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org