From dev-return-57332-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org Wed Oct 13 17:14:53 2010 Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 46380 invoked from network); 13 Oct 2010 17:14:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Oct 2010 17:14:53 -0000 Received: (qmail 51622 invoked by uid 500); 13 Oct 2010 17:14:52 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 51549 invoked by uid 500); 13 Oct 2010 17:14:52 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 51542 invoked by uid 99); 13 Oct 2010 17:14:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Oct 2010 17:14:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Oct 2010 17:14:51 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9DHEUFt020354 for ; Wed, 13 Oct 2010 17:14:31 GMT Message-ID: <33163662.128081286990070918.JavaMail.jira@thor> Date: Wed, 13 Oct 2010 13:14:30 -0400 (EDT) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-2655) Get deletes working in the realtime branch In-Reply-To: <14711524.286371284950972665.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920665#action_12920665 ] Michael McCandless commented on LUCENE-2655: -------------------------------------------- Just to confirm: when a delete is done, we go and buffer that delete into each DWPT, right? (Mapped to the then-current docid-upto for that DWPT). OK I see the problem. It's because we now have a single pool for deletesFlushed, right? Ie, DWPT #2 will overwrite the term id:1 entry. But, I think the switch to generations of pending deletes (LUCENE-2680) would fix this? Maybe we should go do that one first... Ie, DWPT #1's flush would enter a new gen delete pool (maps term -> global docid-upto). Then DWPT #2's flush would also enter a new gen delete pool. Hmm, but not quite... the generations can't simply stack on top of one another. I think there's a graph structure somehow? Ie every DWPT that's flushed must record the segments that existed (were already flushed) when it was first created, because it's only those segments that should get the deleted term. Segments in the future obviously shouldn't get it. And segments from parallel DWPTs (ie that existed at the same time) should also not get it since they will separately track the deleted term. BTW, I think this makes LUCENE-2679 all the more important (the ability to delete such that delete will only apply to already-committed segments), since this'd mean we only store the pending delete in a single map instead of map per DWPT. > Get deletes working in the realtime branch > ------------------------------------------ > > Key: LUCENE-2655 > URL: https://issues.apache.org/jira/browse/LUCENE-2655 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Affects Versions: Realtime Branch > Reporter: Jason Rutherglen > Fix For: Realtime Branch > > Attachments: LUCENE-2655.patch > > > Deletes don't work anymore, a patch here will fix this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org