lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: nocommit committed in SolrCore.java
Date Mon, 25 Oct 2010 09:19:25 GMT
On Mon, Oct 25, 2010 at 2:12 AM, Chris Hostetter
<hossman_lucene@fucit.org> wrote:
>
> : Now we are nocommit-free on trunk & 3.x.
>
> FWIW: we can make hudson fail the build if "nocommit" is found anywhere in
> the source.
>
> Just an idea if people are intersted.

+1!

I can do this easily w/ Python... but does hudson have something
builtin to do things like this already?

Or we can make it a real unit test, which crawls the sources if they
are available, and fails if it finds a nocommit.  This way we'd see
the failure before committing...

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message