lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: svn commit: r1022335 - /lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestCase.java
Date Fri, 15 Oct 2010 21:21:51 GMT
I don't think we should do this.

because the hudson jail has 'tcp blackhole' set, tests should *never*
depend on connecting to a port not accepting connections and getting
an RST (it won't happen).

Thats why this test takes 5 minutes now on hudson... we should fix
similar problems in other tests too.

On Wed, Oct 13, 2010 at 8:52 PM,  <yonik@apache.org> wrote:
> Author: yonik
> Date: Thu Oct 14 00:52:11 2010
> New Revision: 1022335
>
> URL: http://svn.apache.org/viewvc?rev=1022335&view=rev
> Log:
> fix LB tests for those with ISPs that never fail DNS lookups
>
> Modified:
>    lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestCase.java
>
> Modified: lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestCase.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestCase.java?rev=1022335&r1=1022334&r2=1022335&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestCase.java
(original)
> +++ lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestCase.java
Thu Oct 14 00:52:11 2010
> @@ -55,7 +55,9 @@ public abstract class BaseDistributedSea
>   protected String context = "/solr";
>   protected String shards;
>   protected String[] shardsArr;
> -  protected String[] deadServers = {"does_not_exist_54321.com:33331/solr","localhost:33332/solr"};
> +  // Some ISPs redirect to their own web site for domains that don't exist, causing
this to fail
> +  // protected String[] deadServers = {"does_not_exist_54321.com:33331/solr","localhost:33332/solr"};
> +  protected String[] deadServers = {"localhost:33332/solr"};
>   protected File testDir;
>   protected SolrServer controlClient;
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message