lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shai Erera <>
Subject Re: Analyzer forcing tokenStream and reusableTokenStream to be final
Date Tue, 19 Oct 2010 16:58:49 GMT
Which would mean all the implementation needs to do is delete its
tokenStream and rename reusableTokenStream to tokenStream, and be done with
it? Works for me !

Also, if we delete reusaleTokenStream, and if the application used the
@override tag, it'll get a compilation error, which will make the change
even more visible.


On Tue, Oct 19, 2010 at 6:38 PM, Robert Muir <> wrote:

> On Tue, Oct 19, 2010 at 12:26 PM, Uwe Schindler <> wrote:
> > Trunk has new API why not clean all that stuff up? We already have no
> more really old analyzers, as all needed to be upgraded before 3.0. If you
> did not add reset() it’s a bug as its clearly documented to be a must?
> >
> This is an idea: i haven't thought it all through but it should be
> possible in trunk to:
> 1. document the change in runtime that tokenStream is assumed to be
> reusable.
> 2. deprecate or remove reusableTokenStream (it is gone and ignored)
> then existing analyzers work with no or little modifications.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

View raw message