lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-2689) remove NativeFSLockFactory's attempt to acquire a test lock
Date Tue, 05 Oct 2010 15:54:33 GMT


Shai Erera commented on LUCENE-2689:

All tests passed for me.

BTW, according to the code, this method was added due to NFS cache issues, but I agree that
it's useless to call makeLock just to call obtain() some time later on.  It's almost as if
we should make makeLock obtain the lock right away. Is there a reason why we don't do it?
Is it essential to separate it into two calls?

> remove NativeFSLockFactory's attempt to acquire a test lock
> -----------------------------------------------------------
>                 Key: LUCENE-2689
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1, 4.0
> NativeFSLockFactory tries to acquire a test lock the first time a lock is created.  It's
the only LF to do this, and, it's caused us hassle (LUCENE-2421,  LUCENE-2688).
> I think we should just remove it.  The caller of .makeLock will presumably immediately
thereafter acquire the lock and at the point hit any exception that acquireTestLock would've

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message