lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2691) Consolidate Near Real Time and Reopen API semantics
Date Sat, 09 Oct 2010 15:55:30 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919503#action_12919503
] 

Michael McCandless commented on LUCENE-2691:
--------------------------------------------

bq. What's with all of the test dependencies on IndexWriter.getReader() that seemingly don't
have anything to do with NRT? For instance, TestQueryParser.testPositionIncrements() or TestCachingSpanFilter?

This is just because those tests need a reader having just built the index... ie, as long
as there's no other reason to .commit, getting the reader from the writer is perfectly fine.

Plus this only increases test coverage of NRT.

RandomIndexWriter's .getReader method now randomly picks to either get the reader from the
writer, or, to .commit and then open a new reader.

> Consolidate Near Real Time and Reopen API semantics
> ---------------------------------------------------
>
>                 Key: LUCENE-2691
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2691
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>
> We should consolidate the IndexWriter.getReader and the IndexReader.reopen semantics,
since most people are already using the IR.reopen() method, we should simply add::
> {code}
> IR.reopen(IndexWriter)
> {code}
> Initially, it could just call the IW.getReader(), but it probably should switch to just
using package private methods for sharing the internals

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message