lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2655) Get deletes working in the realtime branch
Date Fri, 01 Oct 2010 16:42:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916946#action_12916946
] 

Michael McCandless commented on LUCENE-2655:
--------------------------------------------

bq.  Are you saying we should simply make deletes work (as is, no BytesRefHash conversion)
then cleanup the RT branch as a merge to trunk of the DWPT changes?

Yes!  Just keep using the Map we now use, but now it must be per-DWPT.  And when IW.deleteDocs(Term/Query)
is called, we must go to each DWPT, grab its current docID, and enroll Term/Query -> docID
into that DWPT's pending deletes map.

bq. Also, from what I've seen, deletes seem to work, I'm not sure what exactly Michael is
referring to.

But this is using the long sequenceID right?  (adds 8 bytes per buffered docID).  I think
we wanted to explore ways to reduce that?  Or, if we can make it modal (you only spend these
8 bytes if IW is open in NRT mode), then that's OK?

I was hoping to cleanly separate the DWPT cutover (solves the nasty flush bottleneck) from
the NRT improvements.

> Get deletes working in the realtime branch
> ------------------------------------------
>
>                 Key: LUCENE-2655
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2655
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Realtime Branch
>            Reporter: Jason Rutherglen
>             Fix For: Realtime Branch
>
>         Attachments: LUCENE-2655.patch
>
>
> Deletes don't work anymore, a patch here will fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message