lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2002) improve build/tests
Date Wed, 13 Oct 2010 15:50:35 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920615#action_12920615
] 

Robert Muir commented on SOLR-2002:
-----------------------------------

Is this a race condition?

If i look at suggesters code i notice:
in build()
{code}
    lookup = (Lookup) core.getResourceLoader().newInstance(lookupImpl);
    try {
      lookup.build(dictionary);
{code}

in getSuggestions() 
{code}
    if (lookup == null) {
      LOG.info("Lookup is null - invoke spellchecker.build first");
{code}

seems like lookup could be non-null, but just not contain any items and cause the test to
fail without the warning...

so maybe the issue happens only if your machine is very busy (e.g. when running all the tests
and there are several jvms going) ?


> improve build/tests
> -------------------
>
>                 Key: SOLR-2002
>                 URL: https://issues.apache.org/jira/browse/SOLR-2002
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2002.patch, SOLR-2002_core_contrib.patch, SOLR-2002_dih.patch,
SOLR-2002_lbhttpsolrserver.patch, SOLR-2002_localization.patch, SOLR-2002_lucenetestcase.patch,
SOLR-2002_merged.patch, SOLR-2002_merged.patch, SOLR-2002_merged.patch, SOLR-2002_merged.patch,
SOLR-2002_replication.patch, SOLR-2002_testiter.patch, SOLR-2002_testmethod.patch, SOLR-2002_timeout.patch,
SOLR-2002setupteardown.patch
>
>
> we are working on improving some functionality in lucene's build/tests, it would be good
to improve the solr side to take advantage of it.
> currently its only sorta-kinda integrated and a bit messy.
> i'd like to do some incremental improvements piece-by-piece on this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message