lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator
Date Sat, 16 Oct 2010 20:46:22 GMT


Robert Muir commented on LUCENE-2671:

bq. What part of the API is broken? 


bq. The assumptions about what is in the Map are are internal to a private member that can
not be touched outside this ugly class.

This is a public class.

It is parameterized as T extends DocTerms, but 
  public T create(IndexReader reader) throws IOException {

This is not true, it returns DocTermCreator.DocTermsImpl and gives an ugly cast
    final T t =
      (T)new DocTermsImpl(bytes.freeze(true), docToOffset.getMutable());
    return t;

The api doesn't look extensible to me, I'm surprised it works. I guess this is why the compiler

Granted i didnt take a lot of time to look it over, but the compiler warnings speak loudly
enough in my favor.

> Add sort missing first/last ability to SortField and ValueComparator
> --------------------------------------------------------------------
>                 Key: LUCENE-2671
>                 URL:
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 4.0
>         Attachments: LUCENE-2671-caches.patch, LUCENE-2671-SortMissingLast.patch, LUCENE-2671-suppress-unchecked.patch
> When SortField and ValueComparator use EntryCreators (from LUCENE-2649) they use a special
sort value when the field is missing.
> This enables lucene to implement 'sort missing last' or 'sort missing first' for numeric
values from the FieldCache.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message