lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2689) remove NativeFSLockFactory's attempt to acquire a test lock
Date Tue, 05 Oct 2010 16:28:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918059#action_12918059
] 

Michael McCandless commented on LUCENE-2689:
--------------------------------------------

bq. BTW, according to the code, this method was added due to NFS cache issues,

Yeah, but, we now recommend SimpleFSLockFactory for NFS... so I think it's OK to remove this,
now.

I think the makeLock/obtain/release separation is OK?  Ie a Lock is stateful (eg can have
an open file) so it makes sense that we return a real object...

> remove NativeFSLockFactory's attempt to acquire a test lock
> -----------------------------------------------------------
>
>                 Key: LUCENE-2689
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2689
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1, 4.0
>
>
> NativeFSLockFactory tries to acquire a test lock the first time a lock is created.  It's
the only LF to do this, and, it's caused us hassle (LUCENE-2421,  LUCENE-2688).
> I think we should just remove it.  The caller of .makeLock will presumably immediately
thereafter acquire the lock and at the point hit any exception that acquireTestLock would've
hit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message