lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency
Date Thu, 14 Oct 2010 09:21:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920895#action_12920895
] 

Simon Willnauer commented on LUCENE-2702:
-----------------------------------------

bq. Is BytesRefHash#get(int) currently not used anywhere except tests, because you had to
change nothing?
no currently not since consumers like TermVectorsTermsWriter go through the ParallelPostingsArray
and access the shared ByteBlockPool directly - they somewhat bypass the get method call though.
We left that in during the refactoring.

bq. +1, thanks for taking care!. As soon as this is committed I can change the patch for LUCENE-2690.
alright - I might do that in one go though.

> BytesRefHash#get() should expect a BytesRef instances for consistency
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2702
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2702
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>         Attachments: LUCENE-2702.patch
>
>
> BytesRefHash#get should use a provided BytesRef instances instead of the internally used
scratch. This is how all other APIs currently work and we should be consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message