lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2710) "reproduce with" on test failure isn't right if you manually overrided anything
Date Sat, 16 Oct 2010 09:35:22 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921657#action_12921657
] 

Uwe Schindler commented on LUCENE-2710:
---------------------------------------

+1

Only: If you use StringBuilder, maybe use it to create the complete string reported (upper
part uses "+"). But thats only tests, so not important for perf, just a general style question.

> "reproduce with" on test failure isn't right if you manually overrided anything
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-2710
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2710
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>         Attachments: LUCENE-2710.patch
>
>
> If you run a test with eg -Dtests.codec=SimpleText...
> If it fails, the "reproduce with" fails to include that manual override (-Dtests.codec=SimpleText),
ie it only includes the seed / test class / test method.  So it won't actually reproduce the
fail, in general.
> We just need to fix the "reproduce with" to add any manual overrides....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message