lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2655) Get deletes working in the realtime branch
Date Fri, 01 Oct 2010 19:10:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917004#action_12917004
] 

Michael McCandless commented on LUCENE-2655:
--------------------------------------------

bq. I'm guessing you mean RT?

Duh sorry yes... I'll try to use the right name :)

bq. In the current RT revision, the deletes are held in one map in DW, guess we need to change
that.

Right, one map that maps the del term to the long sequence ID right?  I'm thinking we revert
just this part, and go back to how trunk how buffers deletes (maps to docID), but per-DWPT.

bq. However if we do, why do we need to keep the seq id or docid as the value in the map?
When the delete arrives into the DWPT, we know that any buffered docs with that term/query
need to be deleted on flush?  (ie, lets not worry about the RT search use case, yet). ie2,
we can simply add the terms/queries to a set, and apply them on flush, ala LUCENE-2679?

For the interleaved case.  Ie, LUCENE-2679 is optional -- we still must handle the interleaved
case correctly (and, I think, by default).  But if an app uses the opto in LUCENE-2679 then
we only need a single Set.

Basically, the DWPT change, alone, is hugely valuable and (I think) decouple-able from the
trickier/riskier/RAM-consuminger RT changes.

> Get deletes working in the realtime branch
> ------------------------------------------
>
>                 Key: LUCENE-2655
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2655
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Realtime Branch
>            Reporter: Jason Rutherglen
>             Fix For: Realtime Branch
>
>         Attachments: LUCENE-2655.patch
>
>
> Deletes don't work anymore, a patch here will fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message